Cdx1.6

[andreas-hilti]

No description provided.

[andreas-hilti]

@mtsfoni I have merged main and I have fixed most tests. There are at the moment only 7 failures. One issue is for sure that something goes wrong when downgrading metadata tools (which is based on the protobuf serialization).

[mtsfoni]

The 1.6 branch is a wip with failing tests itself, so it's natuiral that this pr would have failing tests too.

Thank you a lot for the help. Is this ready to merge?

[andreas-hilti]

The 1.6 branch is a wip with failing tests itself, so it's natuiral that this pr would have failing tests too.

Thank you a lot for the help. Is this ready to merge?

Yes, from my point of view the above 4 commits are fine and can be merged into your branch.
The remaining 4 failing tests all go back to the same issue related to metadata tools (from what I can see, the current protobuf serialization implementation only supports the legacy tools, not the components and services:

cyclonedx-dotnet-library/src/CycloneDX.Core/Models/Metadata.cs

Lines 40 to 66 in a42f0bf

	[XmlElement("tools")]
	public ToolChoices Tools { get; set; }
	// this is to support a bug in v1.5 of the protobuf spec
	[XmlIgnore]
	[JsonIgnore]
	[ProtoMember(2)]
	#pragma warning disable 618
	public List<Tool> ProtobufTools
	#pragma warning restore 618
	{
	get => Tools?.Tools;
	set
	{
	if (value == null)
	{
	Tools = null;
	}
	else
	{
	Tools = new ToolChoices
	{
	Tools = value
	};
	}
	}
	}

, but I don't see how this can be changed easily.)

[andreas-hilti]

The remaining issues are related to CycloneDX/specification#276.

[andreas-hilti]

@mtsfoni andreas-hilti@c3a4c70 would be a workaround for the above issue (it does not fix the underlying issue, though). Like this, all tests would pass.

[mtsfoni]

@mtsfoni andreas-hilti@c3a4c70 would be a workaround for the above issue (it does not fix the underlying issue, though). Like this, all tests would pass.

Black magic. But the tests are green. I take it