chore: introduce PR template #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
Member
Author
|
made some changes as discussed wit h the core working group. |
n1ckl0sk0rtge
pushed a commit
to n1ckl0sk0rtge/specification
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
n1ckl0sk0rtge
pushed a commit
to n1ckl0sk0rtge/specification
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a spec PR pops up without any previous discussion, then this usually disturbs me.
A PR w/o a proper issue means somebody skipped the most relevant part: give people a proper understanding of the "problem" and give them the freedom to think about possible solutions freely. Starting with a solution always narrows the view of everybody, and in almost all cases the proposed solution is not the best one.
to guide pull-requests, i propose the following PR template: #579
What do you think about the situation?
(Yes, I opened this PR without any discussion/ticket before. Ironic, isn't it? ;-))