Skip to content

Fix missing type definitions for ComponentData subelements in XML #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkowalleck merged 1 commit into from
Feb 22, 2025
Merged

Fix missing type definitions for ComponentData subelements in XML #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions schema/bom-1.7.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3931,7 +3931,7 @@ limitations under the License.
</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="sensitiveData" minOccurs="0" maxOccurs="unbounded">
<xs:element name="sensitiveData" type="xs:string" minOccurs="0" maxOccurs="unbounded">
Copy link
Member

@jkowalleck jkowalleck Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in JSON its an array of strings.
in protobug it is repeated string.

conclusion: was intended to be unbound string in XML, too

<xs:annotation>
<xs:documentation>
A description of any sensitive data in a dataset.
Expand Down Expand Up @@ -4020,7 +4020,7 @@ limitations under the License.
</xs:documentation>
</xs:annotation>
<xs:sequence>
<xs:element name="description" minOccurs="0" maxOccurs="1">
<xs:element name="description" type="xs:string" minOccurs="0" maxOccurs="1">
Copy link
Member

@jkowalleck jkowalleck Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in JSON its a strings.
in protobug it is string.

conclusion: was intended to be string in XML, too

<xs:annotation>
<xs:documentation>
A description of this collection of graphics.
Expand Down