Skip to content

Conversation

@manuschneider
Copy link
Collaborator

This fixes #367.

New behavior:

  1. The role of left and right indices is exchanged for bosonic UniTensors, while for BlockFermionicUniTensor the order of the indices is inverted.
  2. The rowrank is adapted accodingly
  3. Incoming bonds become outgoing ones and vice versa (redirect)

Unit tests are adapted accordingly. Some corrections in the unit tests were also done where I saw them (replacing size_t by cytnx_int64 etc.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.28%. Comparing base (e87c3a2) to head (2d5fd31).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/DenseUniTensor.cpp 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   32.35%   35.28%   +2.92%     
==========================================
  Files         215      215              
  Lines       36363    33115    -3248     
  Branches    14597    13204    -1393     
==========================================
- Hits        11764    11683      -81     
+ Misses      22659    19516    -3143     
+ Partials     1940     1916      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

this achieves that the output of the Dagger is in the same form as the original tensor
@manuschneider manuschneider added this to the v1.1.0 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent behavior of Transpose()

2 participants