DIP25 - Sealed references updates and fixes

[ibuclaw]

Two more commits to follow, one refactoring of escape.c, and another that implements return scope.

[jpf91]

@ibuclaw OT, but I just tried to build GDC with an older GCC (4.9) and glibc (2.13) and got this error:

In file included from /home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/visitor.h:14:0,
                 from /home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/dsymbol.h:24,
                 from /home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c:16:
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c: In static member function 'static Type* toArgTypes(Type*)::ToArgTypes::argtypemerge(Type*, Type*, unsigned int)':
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c:248:26: error: 'UINT64_MAX' was not declared in this scope
             assert(sz2 < UINT64_MAX - UINT32_MAX);
                          ^
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c:248:39: error: 'UINT32_MAX' was not declared in this scope
             assert(sz2 < UINT64_MAX - UINT32_MAX);
                                       ^
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c: In member function 'virtual void toArgTypes(Type*)::ToArgTypes::visit(TypeStruct*)':
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c:404:69: error: 'UINT64_MAX' was not declared in this scope
                         assert(fieldsz != SIZE_INVALID && fieldsz < UINT64_MAX - UINT32_MAX);
                                                                     ^
/home/build/tmp/patch/gcc-7-20161127/gcc/d/dfrontend/argtypes.c:404:82: error: 'UINT32_MAX' was not declared in this scope
                         assert(fieldsz != SIZE_INVALID && fieldsz < UINT64_MAX - UINT32_MAX);
                                                                                  ^
/home/build/tmp/patch/gcc-7-20161127/gcc/d/Make-lang.in:115: recipe for target 'd/argtypes.o' failed

Looks like one of these files is missing a stdint.h include which seems to be hidden by changes in newer glibc releases.

[ibuclaw]

Yeah, can put it in argtypes.c

[ibuclaw]

Actually, even better, it's part of some ISO compat code:

/* The ISO C99 standard specifies that in C++ implementations these
   macros should only be defined if explicitly requested.  */
#if !defined __cplusplus || defined __STDC_LIMIT_MACROS

I guess this is now no longer the case.

[jpf91]

Looks like phobos needs some updates as well?

[ibuclaw]

Nope, there's something funny going on here that triggers the error. The build error infact shouldn't happen because attributes should be inferred.

[ibuclaw]

Ah wait, yes, you are right.

Minimal test:

module std.stdio;

struct File
{
    this(string name) @safe
    {
        .fopen(name);
    }

}

void fopen(R1)(R1 name)
{   
    import std.internal.cstring;
    name.tempCString;
}

Digging out the changelog for tempCString and I found this dlang/phobos#4746

[ibuclaw]

And lastly, a bunch of fail tests got merged into one file (fail_scope.d), forgot to remove these individual test files.