This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Fix Bug 283: Wrong codegen in expanded CLEANUP_POINT_EXPR.#606
Merged
ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom Jan 28, 2018
Merged
Fix Bug 283: Wrong codegen in expanded CLEANUP_POINT_EXPR.#606ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom
ibuclaw merged 1 commit intoD-Programming-GDC:masterfrom
Conversation
jpf91
approved these changes
Jan 28, 2018
gcc/d/ChangeLog
Outdated
| @@ -1,3 +1,9 @@ | |||
| 2018-01-27 Iain Buclaw <ibuclaw@gdcproject.org> | |||
|
|
|||
| * decl.cc (DeclVisitor::visit(VarDeclaration)): Don't re-used existing | |||
Not all temporaries that require auto destruction have their lifetime restricted to the CLEANUP_POINT_EXPR they are enclosed in. So only leave out variables marked STCexptemp. This fixes a bug where temporaries were being assumed clobbered too early during optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all front-end temporaries that require auto destruction have their lifetime restricted to the
CLEANUP_POINT_EXPRthey are enclosed in. This fixes a bug where temporaries were being assumed clobbered too early during optimization.