DD-377 Improving the cvoc metadata term selection input#52
Merged
janvanmansum merged 3 commits intoDANS-KNAW:external-cvocfrom Mar 3, 2021
Merged
DD-377 Improving the cvoc metadata term selection input#52janvanmansum merged 3 commits intoDANS-KNAW:external-cvocfrom
janvanmansum merged 3 commits intoDANS-KNAW:external-cvocfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The cvoc metadata term selection input should show all possible input in the dropdown without any characters typed for autocomplete
Added are the minChars config option and the hideReadonlyUrls option.
The minChars is 0 by default, resulting in a terms dropdown without any character input, just by typing the up or down arrow keys in the input field.
Using hideReadonlyUrls, which is false by default, you can hide the URL files if they are also readonly. T
Which issue(s) this PR closes:
Closes #DD-377
Special notes for your reviewer:
Suggestions on how to test this:
change the config json for the cvocs and have it use the new options:
"readonly": "true",
"hideReadonlyUrls": "true",
"minChars": "1",
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Complex is showing the URLs, but Period is not.
Is there a release notes update needed for this change?:
Additional documentation: