DD-386: Uses the vocab-uri parameter from the cvoc config#55
Merged
PaulBoon merged 2 commits intoDANS-KNAW:external-cvocfrom Mar 16, 2021
Merged
DD-386: Uses the vocab-uri parameter from the cvoc config#55PaulBoon merged 2 commits intoDANS-KNAW:external-cvocfrom
PaulBoon merged 2 commits intoDANS-KNAW:external-cvocfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the vocab-uri parameter from the cvoc config to store in the metadata
What this PR does / why we need it:
The parent uri was being stored into the cvoc vocabulary URL input field, but that was not working for the Collecties cvoc, where we did not filter on a parent concept.
So we needed to use the true vocabulary URI for the cvocs, even if we only used part of the vocabulary.
This vocabulary URI is now extracted from the config; https://github.com/DANS-KNAW/dd-dtap/pull/94
Which issue(s) this PR closes:
Closes #DD-386
Special notes for your reviewer:
Suggestions on how to test this:
You need to have the updated config (from PR https://github.com/DANS-KNAW/dd-dtap/pull/94)
After building this war file you can deploy it with dd-dtap using; ./deploy-dataverse-mod.sh ../dataverse/target/dataverse-5.3.war
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: