Restore name of loadable module, update extension category#16
Merged
Conversation
This was referenced Jul 22, 2020
Open
|
I am not sure I understand. Why do you want to revert the name? |
Collaborator
|
The name and category changes were initially only intended to be for SALT, not to be merged upstream. We can revert the name back to MFSDA for the version in the Slicer extension store if that is preferred. Keeping it under "Shape Analysis" instead of "Pvalue" probably makes sense though. |
|
Gotcha. Yes, that makes sense, will request that change. |
bpaniagua
requested changes
Jul 23, 2020
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <executable> | |||
| <category>Shape Analysis.Advanced</category> | |||
There was a problem hiding this comment.
Per discussion in PR thread, lets keep this as Shape Analysis.
This commit partially reverts commit 4df8b7a (ENH: Rename modules for SALT) restoring the name of the loadable module from "Covariate Significance Testing" to "MFSDA"
jcfr
changed the title
Author
|
@bpaniagua Please have another look 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4df8b7a.
MFSDA loadable module:
MFSDA. it was changed toCovariate Significance Testing.Pvalues. It was changed toShape AnalysisFor these two CLIs, the category is restored to
Pvalues. It was changed toShape Analysis.AdvancedQuestions
Should we keep the name of the loadable module to
Covariate Significance Testing?Considering that MFSDA stands for
Multivariate Functional Shape Data Analysis, is it sensible to keep the categoryShape Analysis(instead of reverting back toPvalues)?