Skip to content

Bug/done button #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannyleech merged 2 commits into from
May 6, 2026
Merged

Bug/done button #264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1db758
Done button enabling too soon fix
dannyleech May 6, 2026
173ef4b
Main merged
dannyleech May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions plugins/beta/draw-ml/src/modes/createDrawMode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ export const createDrawMode = (ParentMode, config) => {
if (coords.length > 0) {
coords[coords.length - 1] = [e.lngLat.lng, e.lngLat.lat]
}
// For polygon: prevent duplicate-coordinate clicks from reaching ParentMode, which
// would trigger a changeMode chain and cause a runtime error on coords.length access
if (!finishOnInvalidClick && !validateClick(getFeature(state))) {
return
}
}
const coordsBefore = getCoords(getFeature(state)).length
ParentMode.onClick.call(this, state, e)
Expand Down Expand Up @@ -154,15 +159,18 @@ export const createDrawMode = (ParentMode, config) => {
this._simulateMouse('click', ParentMode.onClick, state)
}

// Push undo if a vertex was added
if (getCoords(getFeature(state)).length > coordsBefore) {
// Push undo and update count if a vertex was added
const newCoords = getCoords(getFeature(state))
if (newCoords.length > coordsBefore) {
this.pushDrawUndo(state)
this.dispatchVertexChange(newCoords)
}
},

dispatchVertexChange (coords) {
// Subtract 1 to exclude the rubber-band vertex that mapbox-gl-draw always appends
this.map.fire('draw.vertexchange', {
numVertecies: coords.length
numVertecies: Math.max(0, coords.length - 1)
})
},

Expand Down
Loading