Identify chores related fields in plotinfo.hauling #580
Conversation
|
related function: DFHack/dfhack#2901 (comment) |
Actually read as a single byte. Bitfield or bool? |
df.ui.xml
Outdated
| <int32_t ref-target='unit'/> | ||
| </stl-vector> | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
were these fields just wrong before? why are they commented out now? and can they just be deleted instead of commented?
There was a problem hiding this comment.
I did not check older versions, I guess they were wrong since 0.50.01.
They could be deleted. I followed the trend started by @quietust in cc7c6b1. I think quietust did that so it would be easier to recreate the field when they are found. But now we know there is not enough space for them to be in hauling. If they still exist, they are much further away.
There was a problem hiding this comment.
Indeed, the main reason I commented things out was because a lot of things had changed so I didn't know at the time whether those fields had been removed or simply relocated.
Once it's clear that something has actually been removed, it should be erased from the XML - if it ever comes back, we can look back in the commit history to find it.
There was a problem hiding this comment.
I removed all the comments.
Should have looked at how it is written. It is definitely a 32 bit bitfield. |
3 participants
I am not sure about the bitfield size, but I cannot check right now.
I have no idea where the stuff I'm removing has gone, but it's not the first time in this structure from the comments. There are two bytes of padding after
chores, bools could fit in there.