Skip to content

Conversation

@realSquidCoder
Copy link
Contributor

This code is supposed to note down what the millisecond time is on save or load and be able to return the difference from that time and now to give to notifications.lua

@realSquidCoder realSquidCoder requested a review from myk002 January 15, 2025 21:15
@realSquidCoder
Copy link
Contributor Author

unsure if i missed anything besides docs

@realSquidCoder realSquidCoder marked this pull request as ready for review January 15, 2025 21:23
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs go in Lua API.rst

Co-authored-by: Myk <myk.taylor@gmail.com>
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! all it needs now is changelog entries (API and Lua sections)

@myk002 myk002 merged commit b60c525 into DFHack:develop Jan 16, 2025
14 checks passed
@realSquidCoder realSquidCoder deleted the squid-saverem-api branch January 16, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants