update to canonicalized structures #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
merging so we can run a full test suite in DFHack/dfhack#4631 |
quietust
reviewed
May 24, 2024
| assign={zone_settings={pen={check_occupants=true}}}}}, | ||
| p={label='Pit/Pond', props_fn=parse_pit_pond_props, default_data={type=df.civzone_type.Pond, | ||
| assign={zone_settings={pit_pond=df.building_civzonest.T_zone_settings.T_pit_pond.top_of_pit}}}}, | ||
| assign={zone_settings={pond={flag={keep_filled=true}}}}}}, |
Member
There was a problem hiding this comment.
This should be setting check_occupants=True and keep_filled=False to make it act as a Pit (as the old "top_of_pit" value did) - as it is right now, this setting will make it act like a Pond instead.
Member
There was a problem hiding this comment.
yeah, pit_pond (now pond.flag) changed from an enum to a bitfield - missed that. So I agree, setting 2 before would correspond to setting check_occupants=true now.
Confirmed it was 2 in 50.13-r2.1:
[lua]# ~df.building_civzonest.T_zone_settings.T_pit_pond.top_of_pit
2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: DFHack/df-structures#763