Allow any DID format when token asset matches query DID exactly#69
Merged
Allow any DID format when token asset matches query DID exactly#69
Conversation
Previously, DecodeERC721DID was called before the direct-match check, so did:ethr tokens would fail immediately with "unauthorized" even when token.Asset and the query did were identical. Move the direct-match check first so it handles any DID format. Change filterToSearchOptions to accept a plain string subject so the ERC721DID assumption is removed end-to-end. The device-resolution path (aftermarket/synthetic device → vehicle DID) is unchanged. https://claude.ai/code/session_01R5aqTcL3rKEnPazSjxCCP2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, DecodeERC721DID was called before the direct-match check,
so did:ethr tokens would fail immediately with "unauthorized" even when
token.Asset and the query did were identical. Move the direct-match
check first so it handles any DID format. Change filterToSearchOptions
to accept a plain string subject so the ERC721DID assumption is
removed end-to-end. The device-resolution path (aftermarket/synthetic
device → vehicle DID) is unchanged.
https://claude.ai/code/session_01R5aqTcL3rKEnPazSjxCCP2