This repository was archived by the owner on May 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/list all endpoints as default function #175
Merged
Frank-Wiebeler
merged 6 commits into
main
from
feature/list_all_endpoints_as_default_function
Feb 21, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
593cb86
Add functions to list all endpoints to the default implementation.
saschadoemer 10a2dd8
Add functions to list all endpoints to the default implementation.
saschadoemer 7cf5ad0
Add functions to fetch all messages from the feed.
saschadoemer 1072989
Adapt implementation.
saschadoemer f854079
Adapt implementation.
saschadoemer 546e98b
Adapt implementation.
saschadoemer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 37 additions & 1 deletion
38
...rc/main/java/com/dke/data/agrirouter/api/service/messaging/http/ListEndpointsService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,41 @@ | ||
| package com.dke.data.agrirouter.api.service.messaging.http; | ||
|
|
||
| import com.dke.data.agrirouter.api.dto.onboard.OnboardingResponse; | ||
| import com.dke.data.agrirouter.api.messaging.HttpAsyncMessageSendingResult; | ||
| import com.dke.data.agrirouter.api.service.parameters.ListEndpointsParameters; | ||
|
|
||
| public interface ListEndpointsService extends MessagingService<ListEndpointsParameters> {} | ||
| public interface ListEndpointsService extends MessagingService<ListEndpointsParameters> { | ||
|
|
||
| /** | ||
| * List all endpoints with a route to the dedicated endpoint. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| String listAllWithExistingRoute(OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints for the account, even those that do not have a route. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| String listAll(OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints with a route to the dedicated endpoint. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| HttpAsyncMessageSendingResult listAllWithExistingRouteAsync( | ||
| OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints for the account, even those that do not have a route. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| HttpAsyncMessageSendingResult listAllAsync(OnboardingResponse onboardingResponse); | ||
| } | ||
38 changes: 37 additions & 1 deletion
38
...rc/main/java/com/dke/data/agrirouter/api/service/messaging/mqtt/ListEndpointsService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,41 @@ | ||
| package com.dke.data.agrirouter.api.service.messaging.mqtt; | ||
|
|
||
| import com.dke.data.agrirouter.api.dto.onboard.OnboardingResponse; | ||
| import com.dke.data.agrirouter.api.messaging.MqttAsyncMessageSendingResult; | ||
| import com.dke.data.agrirouter.api.service.parameters.ListEndpointsParameters; | ||
|
|
||
| public interface ListEndpointsService extends MessagingService<ListEndpointsParameters> {} | ||
| public interface ListEndpointsService extends MessagingService<ListEndpointsParameters> { | ||
|
|
||
| /** | ||
| * List all endpoints with a route to the dedicated endpoint. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| String listAllWithExistingRoute(OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints for the account, even those that do not have a route. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| String listAll(OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints with a route to the dedicated endpoint. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| MqttAsyncMessageSendingResult listAllWithExistingRouteAsync( | ||
| OnboardingResponse onboardingResponse); | ||
|
|
||
| /** | ||
| * List all endpoints for the account, even those that do not have a route. | ||
| * | ||
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| MqttAsyncMessageSendingResult listAllAsync(OnboardingResponse onboardingResponse); | ||
| } |
51 changes: 0 additions & 51 deletions
51
...dke/data/agrirouter/convenience/mqtt/service/messaging/ListEndpointsFunctionsService.java
This file was deleted.
Oops, something went wrong.
51 changes: 0 additions & 51 deletions
51
...dke/data/agrirouter/convenience/rest/service/messaging/ListEndpointsFunctionsService.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is only the requesting function and does not directly return the endpoint list, a name that starts with request would be more accurate.
requestAllWithExistingRoute() or requestAllEndpointsWithExistingRoute()
requestAll() or requestAllEndpoints()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since 'request' is based on the HTTP terminology. I would like to stay with the current name. Resolve the conversation if this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, what about queue? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the same name for both of the services and therefore, stick with the current name.