This repository was archived by the owner on May 8, 2026. It is now read-only.
Add functions to delete all messages from the feed.#177
Merged
Conversation
Member
Frank-Wiebeler
left a comment
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Just small typos; can be merged after those were fixed.
DRY principle is violated ( createMessageParametersToDeleteAllMessages ); this should maybe be addressed in an additional PR as it is the case with the other 2 PRs as well.
In general: Awesome work, thank you for your input ヽ(´▽`)/
Member
Author
Fixed the DRY problem with a default implementation on the interface. Not quite sure about the abstraction overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format.