This repository was archived by the owner on May 8, 2026. It is now read-only.
Feature/merge latest release branches to enable trunk development#212
Merged
saschadoemer merged 6 commits intoDec 15, 2023
Merged
Conversation
Formatted the telemetry platform and platform-removed onboarding responses data. The response's payloads are now presented in a more structured, neatly indented JSON format for better readability and clarity.
Adjusted the formatting of the README documentation file to enhance readability and content clarity. The modifications include structuring sentences into separate lines, delivering concise and clear information more efficiently.
The commit updates the formatting of several files for improved readability and also optimizes SVG graphics for faster load times. It primarily involves adding appropriate line breaks and spaces for clarity and enhancing readability in bug report template and the code of conduct. Optimization of SVGs results in more efficient loading and display of images.
Data types of 'code' fields in RevokingError and OnboardingError classes have been changed from strings to integers. This will streamline error handling and avoid potential type conversion errors. The default error code for unknown errors has also been updated from "UNKNOWN_ERROR" to -1.
Disabled two tests in the 'SendChunkedMessageTest' and 'SendChunkedMessageForSingleChunkTest' classes needing further investigation and attributed them to issues #197 and #198 respectively. Created 'SendChunkedMessageForSingleChunkTest' file. Changed the error code assertion from string to integer in 'OnboardingWithErrorMessageTest'.
Removed use of StandardCharsets.UTF_8 in EncodeMessageServiceImpl as the payloads were already in byte format. Eliminating this redundant encoding to UTF_8 from the payload improves efficiency and mitigates potential errors due to unnecessary conversion scenarios.
saschadoemer
deleted the
feature/merge-latest-release-branches-to-enable-trunk-development
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.