This repository was archived by the owner on May 8, 2026. It is now read-only.
Bugfix/remove env from set capabilities service since its not used#216
Merged
oliverrahner merged 4 commits intoMay 16, 2024
Merged
Conversation
This commit removes the unnecessary environment dependency in SetCapabilityServiceImpl's constructor and adjusts all corresponding usages. This makes the SetCapabilityServiceImpl more loosely coupled, enhancing readability and making it easier to maintain. Removal of the parameter also simplifies its instantiation in tests and reduces potential issues related to varying environments.
The unused import, 'com.dke.data.agrirouter.api.env.QA', was removed from the class 'SetCapabilityServiceTest'. This cleanup improves the readability of the code and adheres to good coding practices.
saschadoemer
added
the
breaking-change
saschadoemer
added
contains-something-deprecated
…into bugfix/remove-env-from-set-capabilities-service-since-its-not-used
The SetCapabilityServiceImpl constructor that takes an Environment parameter has been deprecated. A warning message has been added to indicate that this constructor is deprecated, and it should not be used moving forward as it will be removed in a future release. This change aims to streamline the use of the SetCapabilityService requiring no environment parameters.
oliverrahner
approved these changes
May 16, 2024
saschadoemer
deleted the
bugfix/remove-env-from-set-capabilities-service-since-its-not-used
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.