This repository was archived by the owner on May 8, 2026. It is now read-only.
Bugfix/remove duplicate header declaration#217
Merged
Conversation
This change consolidates the creation and acceptance of JSON type requests into a single line in the RequestFactory class. This refactoring boosts code readability and efficiency.
Removed the redundant client creation and configuration logic within the bearerTokenRequest method in the RequestFactory class. Moreover, a separate method is introduced to generate a request with bearer token allowing simplification and code reuse. The change ensures cleaner and more efficient request generation.
The onboarding parameters and response for the farming software tests have been updated. This includes changes to the registration code and a new response in the farming-software.json file which includes new id values and URLs.
In the FarmingSoftwareFixture.java test file, the placeholder for the registration code has been replaced with an actual code and the test case has been enabled. Additionally, the onboarding response for farming-software-deactivated.json has been updated. These changes are essential to ensure that the tests can run successfully and reflect the current state of the system.
The update involves renewing the registration code used in the farming software fixture for tests. Also, the authentication detail of the farming software in the test JSON response is updated to ensure the effectiveness and relevancy of the tests.
The placeholder for the registration code in the test case "onboardAndDeactivateFarmingSoftwareAndSaveToFile" in FarmingSoftwareFixture file has been updated with actual code, and the test case is enabled back for execution. Additionally, relevant changes were made in the "farming-software-deactivated.json" file.
oliverrahner
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.