Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Bugfix/signature verify always true #29

Merged
oliverrahner merged 2 commits into from
Feb 7, 2022
Merged

Bugfix/signature verify always true #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3614ebd
fix recipient list not copied to request envelope
oliverrahner Feb 7, 2022
1658b9d
fixed signature check masking invalid signatures
oliverrahner Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agrirouter/auth/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def verify(self, public_key) -> None:
unquoted_signature = unquote(self.signature)
encoded_signature = base64.b64decode(unquoted_signature.encode("utf-8"))

self._is_valid = True
try:
verify_signature(encoded_data, encoded_signature, public_key)
except InvalidSignature:
Expand All @@ -56,7 +57,6 @@ def verify(self, public_key) -> None:
finally:
self._was_verified = True

self._is_valid = True

@staticmethod
def decode_token(token: Union[str, bytes]) -> AuthorizationToken:
Expand Down
2 changes: 2 additions & 0 deletions agrirouter/messaging/encode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ def encode_header(header_parameters: MessageHeaderParameters) -> RequestEnvelope
if header_parameters.get_team_set_context_id() is not None:
request_envelope.team_set_context_id = header_parameters.get_team_set_context_id()
request_envelope.timestamp.FromDatetime(now_as_utc_timestamp())
if header_parameters.get_recipients() is not None:
request_envelope.recipients.MergeFrom(header_parameters.get_recipients())

return request_envelope

Expand Down