-
Notifications
You must be signed in to change notification settings - Fork 63
Feature: face neighbors and ghosts for handle #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
+ Coverage 77.05% 77.41% +0.36%
==========================================
Files 112 112
Lines 18959 19034 +75
==========================================
+ Hits 14608 14736 +128
+ Misses 4351 4298 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandro-elsweijer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will talk to you in person ;)
| const t8_element_t* | ||
| get_element () const | ||
| { | ||
| return t8_forest_get_leaf_element_in_tree (m_mesh->m_forest, m_tree_id, m_element_id); | ||
| return m_element; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Ideally, the user does not need this. Furthermore, it is confusing that an element has a function named get_element. If the element was called element_handle, then this would make sense, since it is a handle to the underlying element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this function is in the private area so the user does not see it.
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
Closes #1945
Describe your changes here:
The mesh handle is now able to get the face neighbors of a mesh element. For this, ghost functionality is needed. ghost elements and mesh elements are now both childs of an abstract element class containing virtual functions for functionality where the element types. Functionality is provided such that users should not have to do type casts.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).