Merge pull request #3132 from DMPRoadmap/dcc_bug_710-Error_using_unassign_users_from_a_Department_using_API_V0

DCC BUG #710 - Fix for "Error using unassign_users from a Department …

Author: briri

app/controllers/api/v0/departments_controller.rb

@@ -47,16 +47,24 @@ def assign_users
         raise Pundit::NotAuthorizedError unless Api::V0::DepartmentsPolicy.new(@user, @department).assign_users?
 
         assign_users_to(@department.id)
-        redirect_to users_api_v0_departments_path
+
+        # Added "status: :see_other" to redirect_to (as we require rediect to be a GET).
+        # See https://makandracards.com/makandra/38347-redirecting-responses-for-patch-or-delete-will-not-redirect-with-get
+        redirect_to users_api_v0_departments_path, status: :see_other
       end
 
       ##
       # Remove departments from the list of users
       def unassign_users
-        raise Pudndit::NotAuthorizedError unless Api::V0::DepartmentsPolicy.new(@user, @department).assign_users?
+        @department = Department.find(params[:id])
+
+        raise Pundit::NotAuthorizedError unless Api::V0::DepartmentsPolicy.new(@user, @department).assign_users?
 
         assign_users_to(nil)
-        redirect_to users_api_v0_departments_path
+
+        # Added "status: :see_other" to redirect_to (as we require rediect to be a GET).
+        # See https://makandracards.com/makandra/38347-redirecting-responses-for-patch-or-delete-will-not-redirect-with-get
+        redirect_to users_api_v0_departments_path, status: :see_other
       end
 
       private

config/routes.rb

@@ -162,9 +162,9 @@
       resources :departments, only: %i[create index] do
         collection do
           get :users
-          patch :unassign_users
         end
         member do
+          patch :unassign_users
           patch :assign_users
         end
       end