DCC BUG #710 - Fix for "Error using unassign_users from a Department … #3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using API V0". Fix for DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/710 Changes: - the route for PATCH unassign_users_api_v0_department was wrongly defined, it was missing the parameter for department id. - In app/controllers/api/v0/departments_controller.rb - fixed a typo in unassign_users() method raise Pudndit::NotAuthorizedError instead of Pundit::NotAuthorizedError - in assign_users() and assign_users() the redirect_to was failing as it was treated as a PATCH based on original API call, rather than being redirect as GET. Fixed by adding status "See Other" to redirect_to redirect_to users_api_v0_departments_path, status: :see_other based on https://makandracards.com/makandra/38347-redirecting-responses-for-patch-or-delete-will-not-redirect-with-get
…s_from_a_Department_using_API_V0
…s_from_a_Department_using_API_V0
briri
deleted the
dcc_bug_710-Error_using_unassign_users_from_a_Department_using_API_V0
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…using API V0".
Fix for DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/710
Changes:
defined, it was missing the parameter for department id.
instead of Pundit::NotAuthorizedError
as it was treated as a PATCH based on original API call, rather than
being redirect as GET. Fixed by adding status "See Other" to
redirect_to
redirect_to users_api_v0_departments_path, status: :see_other
based on https://makandracards.com/makandra/38347-redirecting-responses-for-patch-or-delete-will-not-redirect-with-get