addresses 1091 #1100
Merged
addresses 1091 #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine to me Sam. Just need to fix the broken test. Feel free to merge yourself once its passing |
jollopre
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated load_for_phase function and num_answered_questions on the plans model
num_answered_questions needed changed to go via the plan.template.phases.sections.questions, instead of plan.sections.questions
Prefetch updated on load_for_phase to run in one query thanks to a .joins() along with an includes.
This pattern seems to force all includes statements to run within the initial query and is a pattern we can re-use in future
Appologies for the noise in the diffs, my editor rips trailing whitespace