Orgs Autocomplete #2836
Merged
Orgs Autocomplete #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line used to be:
if orgs.present? && params.fetch(:funder_only, "false") == true
but that didn't work because the param is a string so it was changed to
if orgs.present? && params.fetch(:funder_only, false)
which looks better but doesn't work either for the same reason
(try something like
puts "hello" if "false"
)
so it needs to be
if orgs.present? && params.fetch(:funder_only, "false") == "true"
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Orgs Autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line used to be:
if orgs.present? && params.fetch(:funder_only, "false") == true
but that didn't work because the param is a string so it was changed to
if orgs.present? && params.fetch(:funder_only, false)
which looks better but doesn't work either for the same reason
(try something like
puts "hello" if "false"
)
so it needs to be
if orgs.present? && params.fetch(:funder_only, "false") == "true"