Org selector refactor #2858
Merged
Org selector refactor #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test for home page failed when org admin
… in' nav menu item to redirect to root_path
raycarrick-ed
approved these changes
Apr 7, 2021
Contributor
raycarrick-ed
left a comment
raycarrick-ed
left a comment
There was a problem hiding this comment.
That is a lot neater. Excellent.
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Org selector refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raycarrick-ed I noticed that the 'Add contributor' page was failing because it was not setting the
org_partial. I also noticed that the 'Sign in' menu was still trying to open the modal sign in/create account form that you removed.This PR refactors those recent changes a bit.
@all_orgsand@org_partialto the OrgSelectable concern which sets them in abefore_actionhookroot_pathinstead of trying to open the modal popup that was removed