Skip to content

Conversation

@raycarrick-ed
Copy link
Contributor

Filename for pdf export is derived from plan title. If it has quotes in it, this fails in chrome. This removes the quotes.

@raycarrick-ed raycarrick-ed requested a review from briri April 20, 2021 12:26
@briri
Copy link
Contributor

briri commented Apr 20, 2021

looks good @raycarrick-ed just a very minor rubocop complaint then go ahead and merge after that

space and quotes apparently not right
@raycarrick-ed raycarrick-ed merged commit 34e52c0 into master Apr 21, 2021
@briri briri deleted the bug_pdf_chrome branch September 8, 2021 21:31
@nicolasfranck
Copy link
Contributor

nicolasfranck commented Oct 15, 2021

Is this actually enough as a check? I can imagine that tomorrow other characters will emerge. What if someone adds emoticons?

I think that a filename like plan_<plan_id>_phase_<phase_id>.pdf would be much safer,
and you do not have to worry about future bugs anymore.

e.g. a title like "Relax, Accept & Regulate": Experimental research on the sequence of emotion regulation. after this fix leads to a filename called Relax,_Accept_&_Regulate__Experimental_research_on_the_sequence_of_emotion_regulation..pdf. Not really an improvement ;-)

nicolasfranck added a commit to DMPbelgium/roadmap that referenced this pull request Oct 15, 2021
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
pdf export filename with quotes fails in chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants