Skip to content

Add pagination/sort/search args to the query string #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briri merged 5 commits into from
Jul 26, 2021
Merged

Add pagination/sort/search args to the query string #2959

briri merged 5 commits into from
Jul 26, 2021

Conversation

@briri
Copy link
Contributor

@briri briri commented Jun 25, 2021

Part of #2930

  • Updates the public plans and public templates pages so that the pagination/sort/search functionality performs a normal http GET instead of an ajax request and ensures that the page, search sort_field and sort_direction are conveyed in the query string.

@briri briri requested a review from raycarrick-ed July 19, 2021 17:08
@briri
Copy link
Contributor Author

briri commented Jul 20, 2021

@raycarrick-ed please review when you have a chance

@briri briri merged commit 8e93c60 into development Jul 26, 2021
@briri briri deleted the pagination-in-query-string branch July 26, 2021 20:54
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
@briri
Merge pull request DMPRoadmap#2959 from DMPRoadmap/pagination-in-quer…
65dae48 
…y-string

Add pagination/sort/search args to the query string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raycarrick-ed raycarrick-ed Awaiting requested review from raycarrick-ed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briri