New maDMP additions for the project details page #2986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maDMP features
Other features/fixes
plan.funder_idfrom being set to nilapp/javascript/src/utils/conditionalFields.jsfile that allows you to define sets of fields that are hidden/shown. Currently using it to hides/show the Description and Report URL if the ethical issues checkbox is not checked and the Grant and Funding Status fields if no Funder is selected.grantgetter and setter overrides to the Plan model to allow the grant to be loaded and set properly from incoming UI params.plan.owneras the data contact if available (otherwise the contributor who is the :data_curator)ethical_issuesfieldsresearch_domainas a :keywordplan.orgas a :dmproadmap_funded_affilaition to deal with scenarios where theplan.orgdoes not match the orgs defined for the owner or contributorsplan.identifieras :dmproadmap_funding_opportunity_numberDB Changes
data_contact,principal_investigator,grant_numberandfunder_namefields from theplanstable since they have been replaced with associations to contributors, identifiers and orgsrails external_apis:add_field_of_science_to_research_domainsthat populates the newresearch_domainstable