Skip to content

Conversation

@johnpinto1
Copy link
Contributor

@johnpinto1 johnpinto1 commented Sep 13, 2021

…an wizard page is completed"

Fixes https://github.com/DigitalCurationCentre/DMPonline-Service/issues/584 (DCC issue)
Changes:

  • In plans_controller.rb: save funder selected in
    • added funders to show() method for the use by the partial
      "shared/org_selectors/local_only" in _project_details.html.erb
    • update() method changed to receive params for funder
  • In _project_details.html.erb added "shared/org_selectors/local_only"
    for funders.

…an wizard page is completed"

Changes:
- In plans_controller.rb: save funder selected in
  - added funders to show() method for the use by the partial
    "shared/org_selectors/local_only" in _project_details.html.erb
  - update() method changed to receive params for funder
- In _project_details.html.erb added "shared/org_selectors/local_only"
for funders.
@johnpinto1 johnpinto1 force-pushed the bug_584_not_possible_to_add_funder_once_plan_creation_wizard_completes branch from 6767f85 to 0f11c8c Compare September 13, 2021 11:44
Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good John. Thanks!

@briri briri merged commit 2002092 into development Sep 13, 2021
@briri briri deleted the bug_584_not_possible_to_add_funder_once_plan_creation_wizard_completes branch September 13, 2021 14:23
@briri briri mentioned this pull request Oct 1, 2021
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
…le_to_add_funder_once_plan_creation_wizard_completes

Issue #584 - Fix for "Not possible to add funder once the creation pl…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants