Tinymce label fix #3032
Merged
Tinymce label fix #3032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycarrick-ed
approved these changes
Sep 22, 2021
Contributor
raycarrick-ed
left a comment
raycarrick-ed
left a comment
There was a problem hiding this comment.
Looks good to me. Not an easy one to catch.
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Tinymce label fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something else, I noticed that the existing Tinymce JS was connecting the editor to the incorrect labels. This can cause problems for screen reader accessibility.
The old code was changing the
forattribute of ALL labels on the form. This change ensures that it updates only the related label.