Issue #2958 - Fix for Download option "unanswered questions" does #3039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opposite. Changes to following views in shared/export: - _plan.erb & _plan_txt.erb: In the questions code block added a missing check for whether the question should be displayed. This required moving some of the variables evaluated from lower down in the code, as we need them for our check here.
briri
requested changes
Sep 30, 2021
Apologies to @johnpinto1 for editing his file but for a one line change I didn't think it was worth holding things up. I removed the first blank declaration since it wasn't used until after the second blank declaration. That seemed tidier to me.
Contributor
raycarrick-ed
left a comment
raycarrick-ed
left a comment
There was a problem hiding this comment.
looks fine to me now.
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
…options_unaswered_questions_bug Issue DMPRoadmap#2958 - Fix for Download option "unanswered questions" does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opposite.
Fixes #2958 .
Changes to following views in shared/export:
added a missing check for whether the question should be displayed. This
required moving some of the variables evaluated from lower down in the code, as we need them for our check here.
Here are screenshots of results for options: question text and section headings & unanswered question
PDF
TXT
DOCX
Here are screenshots of results for options: question text and section headings
PDF
TXT
DOCX
