Issue #2955 - UserMailer#permissions_change_notification receives in… #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect user Changes: - Added an instance variable @recepient = @role.user to permissions_change_notification() method in roles_controller and removed instance variable @username and replaced @role.user.email by @recepient.email. - Replaced username with recepientname = @recepient.name in permissions_change_notification.html.erb
johnpinto1
force-pushed
the
bug_2955_usermailer_permissions_change_notification_receives_incorrect_user
branch
from
68a444e to
7e7e558
Compare
briri
approved these changes
Oct 25, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
looks good @johnpinto1. Thanks for patching this!
Contributor
|
rubocop issues are a known issue, so going to merge this |
briri
deleted the
bug_2955_usermailer_permissions_change_notification_receives_incorrect_user
branch
Contributor
Author
|
@briri Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…correct user
Fixes #2955 .
Changes:
permissions_change_notification() method in roles_controller and removed
instance variable @username and replaced @role.user.email by
@recepient.email.