Issue #2941 - Make the display of the phome number in the Plan #3067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributor form configurable. Fix for #2941 Changes: - Added a property a boolean valued property config.x.application.display_contributor_phone_number to config/initializers/_dmproadmap.rb. - Wrapped the phone number field in app/views/contributors/_form.html.erb in a if Rails.configuration.x.application.display_contributor_phone_number statement.
briri
approved these changes
Nov 17, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
looks great. Thanks @johnpinto1
…number-requirement-configurable
briri
deleted the
Bug_2941-make-DMP-contributors-phone-number-requirement-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributor form configurable.
Fix for #2941
Changes:
app/views/contributors/_form.html.erb in a if Rails.configuration.x.application.display_contributor_phone_number statement.
Note: if property not set in config/initializers/_dmproadmap.rb the phone number will not be displayed.