Skip to content

Conversation

@briri
Copy link
Contributor

@briri briri commented Feb 25, 2022

Fixes #3114

Changes proposed in this PR:

  • The Org email was not being displayed if there were no links defined. This fix ensures that the email shows regardless of thee presence of the links.

@johnpinto1 and @raycarrick-ed you may need to apply these changes to your branded versions of the file to address @magdalenadrafiova issue.

  • Also commented out Karma JS tests due to some dependency issues. These tests could be easily replaced with our standard RSpec feature tests (it doesn't really make sense to have 2 test engines anyway imo)

@briri briri merged commit 30fa844 into development Mar 3, 2022
@briri briri deleted the fix-branding-emails-links branch March 3, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants