Skip to content

Updated the font_face value in DEFAULT_SETTINGS from 'Arial, Helvetic… #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martaribeiro merged 3 commits into from
Oct 16, 2023
Merged

Updated the font_face value in DEFAULT_SETTINGS from 'Arial, Helvetic… #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
488072a
Updated the font_face value in DEFAULT_SETTINGS from 'Arial, Helvetic…
don-stuckey Sep 15, 2023
06bd855
Added entry to in Fixed section for this change.
don-stuckey Sep 15, 2023
5d1281b
Moved the fixed-entry for this issue to the top the CHANGELOG.md file.
don-stuckey Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

### Fixed
- Updated the default font on the 'Download page' to be 'Roboto, Arial, Sans-Serif'

## v4.1.0

**Note this upgrade is a migration from Ruby v2.7.6 to v3.0.5.** Note that this could have an impact on any customizations you may have made to your fork of this project. Please see https://www.fastruby.io/blog/ruby/upgrades/upgrade-ruby-from-2.7-to-3.0.html for further information on what to check. In particular, please note the changes to the way [Ruby 3 handles keyword arguments](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/)
Expand Down
2 changes: 1 addition & 1 deletion app/models/settings/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Template < RailsSettings::SettingObject
left: 12,
right: 12
},
font_face: 'Arial, Helvetica, Sans-Serif',
font_face: 'Roboto, Arial, Sans-Serif',
font_size: 10 # pt
},
max_pages: 3,
Expand Down