Fix MySQL and PostgreSQL GitHub Actions #3376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://github.com/titusfortner/webdrivers: "If you can update to the latest version of Selenium (4.11+), please do so and stop requiring this gem."
Without this modification, the selenium tests often trigger a 429 / Too Many Requests error. (Perhaps this should be applied to "/users/password" as well?)
Prior to this commit, the following deprecation warning was appearing in the terminal: NOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10. More here: faker-ruby/faker#2733
Prior to this commit, the GitHub Actions associated with these files were failing with the message, "Invalid workflow file The workflow is not valid. .github/workflows/mysql.yml (Line: X, Col: Y): 'node-version' is already defined"
Contributor
|
Looks good. Updating webdriver and getting rid of issues with Github Actions. |
NOTE: Additional Rubocop offences currently exist in the codebase. These fixes only address the PR changes that correspond with this commit.
johnpinto1
approved these changes
Mar 25, 2024
aaronskiba
added a commit
that referenced
this pull request
Mar 26, 2024
aaronskiba
added a commit
that referenced
this pull request
Mar 26, 2024
aaronskiba
added a commit
that referenced
this pull request
Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3347
Changes proposed in this PR:
rack-attackfrom throttling "/users/sign_in" path on Rails test environmentNOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10.(More here: Generate safeemailanddomain_nameby default (RFC 2606) faker-ruby/faker#2733)mysql.ymlandpostgres.ymlworkflows by removing duplicatenode-version:statements