replaced instances of 'let' with 'var' in js files. #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line cannot handle 'let' at this version
johnpinto1
pushed a commit
to DigitalCurationCentre/roadmap
that referenced
this pull request
May 25, 2021
…dmin rights in
their organisation has their organisation changed the user retained the
Org Admin rights (when they should have been deleted).
The attribute_changed? callback has been removed in Rails 5.2, so we
need to use saved_change_to_attribute?.
So in our case, we replaced :org_id_changed? with :saved_change_to_org_id? in the after_update callbacks in the User model:
after_update :clear_department_id, if: :saved_change_to_org_id?
after_update :delete_perms!, if: :saved_change_to_org_id?, unless: :can_change_org?
after_update :remove_token!, if: :saved_change_to_org_id?, unless: :can_change_org?
The following tests in spec/models/user_spec.rb were replacements:
it "destroys user perms" do
expect(user.perms.count).to eql(0)
end
it "resets api_token to be nil" do
expect(user.api_token).to be_nil
end
portagenetwork
referenced
this pull request
in portagenetwork/roadmap
Feb 24, 2022
…s in
their organisation has their organisation changed the user retained the
Org Admin rights (when they should have been deleted).
The attribute_changed? callback has been removed in Rails 5.2, so we
need to use saved_change_to_attribute?.
So in our case, we replaced :org_id_changed? with :saved_change_to_org_id? in the after_update callbacks in the User model:
after_update :clear_department_id, if: :saved_change_to_org_id?
after_update :delete_perms!, if: :saved_change_to_org_id?, unless: :can_change_org?
after_update :remove_token!, if: :saved_change_to_org_id?, unless: :can_change_org?
The following tests in spec/models/user_spec.rb were replacements:
it "destroys user perms" do
expect(user.perms.count).to eql(0)
end
it "resets api_token to be nil" do
expect(user.api_token).to be_nil
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails' asset pipeline cannot handle 'let' when precompiling assets. Switched all instances to 'var'