Xsrust/mvp #436, #158 #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ised auth for public pages
briri
reviewed
Jul 27, 2017
app/controllers/plans_controller.rb
Outdated
| # Org name of plan owner | ||
| @affiliation = @plan.owner.org.name | ||
| # set the funder name | ||
| @funder = @plan.template.org.funder? ? @plan.template.org.name : nil |
Contributor
There was a problem hiding this comment.
should we use @plan.funder here as well? The create plan process auto-populates that field now but is likely not applicable to existing data. I'll make a note in the ticket to have @sjDCC and @stephaniesimms review the different scenarios in UAT. No need for you to change now ... enjoy your time off!
Contributor
|
Looks good @xsrust. I like the move to a dedicated controller/policy object for these public pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #436 and #158.
Also re-factors public actions to a new controller and applies auth to that controller