Skip to content

Conversation

@xsrust
Copy link
Contributor

@xsrust xsrust commented Aug 17, 2017

Best to look at the commits seperately for code review:

Updated display of publish/unpublish buttons

  • changed logic on template index page to
    • only display 'you have unpublished changes' if the template has been modified, not just viewed
    • does not display publish or unpublish options when 'transfer customization' id displaying, as both are invalid options
  • ensured that all actions on a template cause the 'dirty' flag to be set. (annotation updates and transfer/creation of customization were not setting this flag)

Updated plan creation logic to dissallow outdated customizations

  • ensures that only up to date customizations of the most current funder template are given to users to create plans based off of. This will be clear from the messaging the user recieves upon plan creation, i.e. it will not say that their template has been customised.

Updated rake task to remember which annotations should be preserved

  • Now remembers which annotations have already had their text de-duplicated, and excludes them from future selection

@vyruss vyruss self-requested a review August 17, 2017 14:45
@vyruss vyruss merged commit c85e75b into DMPRoadmap:development Aug 17, 2017
@vyruss vyruss mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants