Skip to content

Update compatibility metadata for KSP 1.12.5#98

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
DMagic1:masterfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5-metadata
Closed

Update compatibility metadata for KSP 1.12.5#98
Sean-Kenneth-Doherty wants to merge 1 commit into
DMagic1:masterfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5-metadata

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

Updates the release metadata for a KSP 1.12.5-compatible 1.4.4 build:

  • bumps the AVC version and assembly metadata from 1.4.3 to 1.4.4
  • updates the supported KSP range through KSP 1.12.x
  • fixes the existing trailing comma in DMagicOrbitalScience.version so the file parses as strict JSON
  • adds a short changelog entry

This overlaps with the compatibility intent in #97, but keeps a conservative KSP 1.12.x upper bound instead of removing the cap entirely, and includes the strict JSON cleanup plus build validation.

Validation

  • python -m json.tool GameData/DMagicOrbitalScience/DMagicOrbitalScience.version
  • xbuild /p:Configuration=Release /p:ReferencePath="/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/KSP_Data/Managed" /p:IntermediateOutputPath="obj/Release/" /p:OutputPath="../GameData/DMagicOrbitalScience/Plugins/" Source/DMagicOrbital.csproj
    • build succeeded against KSP 1.12.5.3190 assemblies with one pre-existing CS0108 warning
  • monodis --assembly GameData/DMagicOrbitalScience/Plugins/DMagic.dll
    • reports Version: 1.4.4.0

I have not done an in-game smoke test yet.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] Update compatibility metadata for KSP 1.12.5 Update compatibility metadata for KSP 1.12.5 May 17, 2026
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5-metadata branch May 18, 2026 02:01
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty restored the codex/ksp-1.12.5-metadata branch May 18, 2026 02:03
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Closing this under the stricter review bar: this is mostly compatibility/version metadata and overlaps existing release discussion without a maintainer request or KSP 1.12.5 runtime proof. A narrowed JSON-only repair could be revisited separately if useful, but I do not want to spend maintainer review time on this PR as-is.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5-metadata branch May 18, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant