NEW PROVIDER: Netbird DNS Zone

[yzqzss]

https://docs.netbird.io/manage/dns/custom-zones
https://docs.netbird.io/api/resources/dns-zones

---

Integration Test Result:

Netbird does not currently support MX and TXT records, so three tests that rely on TXT/MX failed. Otherwise, all good.

$ go test -profile NETBIRD
Testing Profile="NETBIRD" (TYPE="NETBIRD")
--- FAIL: TestDNSProviders (29.07s)
    --- FAIL: TestDNSProviders/test.internal (28.98s)
        --- FAIL: TestDNSProviders/test.internal/85:IGNORE_main:ignore_label (0.08s)
            helpers_integration_test.go:225: Expected 0 corrections on FIRST run, but found 2.
            helpers_integration_test.go:227: UNEXPECTED #0: + CREATE bar.test.internal A 5.5.5.5 ttl=300
            helpers_integration_test.go:227: UNEXPECTED #1: + CREATE mail.test.internal CNAME ghs.googlehosted.com. ttl=300
        --- FAIL: TestDNSProviders/test.internal/86:IGNORE_apex:apex_label (0.10s)
            helpers_integration_test.go:225: Expected 0 corrections on FIRST run, but found 2.
            helpers_integration_test.go:227: UNEXPECTED #0: + CREATE bar.test.internal A 5.5.5.5 ttl=300
            helpers_integration_test.go:227: UNEXPECTED #1: + CREATE mail.test.internal CNAME ghs.googlehosted.com. ttl=300
        --- FAIL: TestDNSProviders/test.internal/88:IGNORE_wilds:ignore_label=foo.* (0.09s)
            helpers_integration_test.go:225: Expected 0 corrections on FIRST run, but found 2.
            helpers_integration_test.go:227: UNEXPECTED #0: + CREATE bar.bat.test.internal A 5.5.5.5 ttl=300
            helpers_integration_test.go:227: UNEXPECTED #1: + CREATE mail.bat.test.internal CNAME ghs.googlehosted.com. ttl=300
Testing Profile="NETBIRD" (TYPE="NETBIRD")
Testing Profile="NETBIRD" (TYPE="NETBIRD")
Testing Profile="NETBIRD" (TYPE="NETBIRD")
FAIL
exit status 1
FAIL    github.com/StackExchange/dnscontrol/v4/integrationTest  29.161s

[TomOnTime]

Now that the org move is complete, I'm sending a friendly ping to PRs. Please rebase and I'd be glad to re-review. Thank you for your patience!

[yzqzss]

Hi, thank you for your review, DNSContrl is very useful to me.
I'll rebase and address your comments soon.

[yzqzss]

ready for review :)

[yzqzss]

Integration test result is the same as before, still failed on those MX/TXT cases.

[TomOnTime]

Hello!

Looking good so far!

Since MX/TXT records are supported, please add this to the tests that fail:

integrationTest/integration_test.go

      not("NETBIRD"),  // MX/TXT records not supported

[cafferata]

Nice addition! The documentation is well-structured and covers configuration, metadata, usage, and activation clearly. A few smaller points from my review as inline comments.

Optionally: since #4208 landed before this PR, would you be open to implementing RegisterCredsMetadata()? That would make NetBird available in dnscontrol init. The PR has examples for simple providers like BIND and more complex ones like TransIP.

[cafferata]

All feedback addressed. Thanks!

[TomOnTime]

Thank you for contributing this new provider, @yzqzss yzqzss !

Two important notes:

1. @fm: Faisal Misle is our “liaison to maintainers”. He'll reach out to you soon. He'll be requesting your email address so that we have a more direct way to contact you. I promise he’s not a spammer!
2. By now you should have received a Github invite to have the "triage" role for this repo. Please accept the invite so we can assign bugs to you.

Thanks again!
Tom

[fm]

Hi @yzqzss

Thank you for becoming the new maintainer for Netbrid.

We want to make sure this is the address you'd like to be reached at regarding maintainer communications. Your email will not be public and will only be used the the project team to send out maintainer communications. Can you email dnscontrol at faisal dot fm from your preferred address?

As a maintainer, we’d like to remind you of your role and expectations we have so that everyone has a positive experience using dnscontrol:

• Maintainers are expected to support their provider. If a maintainer is no longer able to maintain a provider, they should suggest a replacement or if no replacement is available, the maintainer shall let the maintainer liaison know so they can put out a call for volunteers.
• Maintainers must be responsible to bug reports and PRs for their provider.
• Maintainers should set up test accounts and periodically verify that all tests pass (pkg/js/parse_tests and integrationTest), especially when new features are added or changed in the core product.
• Contributors are encouraged to add new tests and refine old ones. (Test-driven development is encouraged.)

If there is anything we can help with, or help unblock, as you maintain your provider please don’t hesitate to reach out.