Allow TXTMulti for provider Hetzner#963
Merged
tlimoncelli merged 2 commits intoNov 28, 2020
Merged
Conversation
Contributor
|
Thanks for fixing that. You'd be surprised how many times we've found providers have a feature that works and just needs the capability enabled. |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The Hetzner provider doesn't allow TXTMulti. Hence, creating DKIM TXT records with >255 bytes fails.
Solution
In that PR I just enabled TXTMulti. For testing purposes I've successfully created, updated and verified a DKIM record against the Hetzner DNS API. Even the verification with a DKIM record checker succeeded. Therefore, I propose to enable TXTMulti for the provider.