-
Notifications
You must be signed in to change notification settings - Fork 19
premium service #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richard-jones
wants to merge
53
commits into
develop
Choose a base branch
from
feature/4008_premium
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
premium service #2465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RK206
approved these changes
Jun 6, 2025
Contributor
RK206
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Steven-Eardley
approved these changes
Jun 9, 2025
… loads them, and another which can take the pdd tar and extract the 100 most recent records. Config change for PDD run and bugfix on article fixture generator
Contributor
|
Few quick tweaks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Current and Free tier of data services
Introduces current-data and free-data access tiers for:
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constantsormessagesfilesdates)url_fornot hard-codeddevelopReviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constantsormessagesfilesdates)url_fornot hard-codeddevelopTesting
User testing
Functional test scripts for premium service
https://doaj.github.io/doaj-docs/feature/4008_premium/testbook/index.html#premium_subscription/premium_access
No particular regression testing is required
Operational testing
I think it would be a good idea to get this up onto a test server and simulate the deployment and phase in process. We could adjust the config to shorten the delay time to speed up the testing:
This would allow us to see the premium mode phase in and then start to operate normally over the course of a week.
To do this, we have developed the following plan:
PREMIUM_PHASE_IN_STARTand a 7 day non_premium delay.portality/scripts/add_sample_journals_and_articles.pyportality/scripts/top_100_records_from_pdd.py. This works over both Journal and Article PDD files. Use as follows:Deployment
Configuration changes
The following fields are added and may need new production configuration values:
The following fields are changed, and will need new production configuration values
The following fields have been removed
Initial deployment configuration
On the day of release the following configuration values from the above will need to be set with custom values different from the
settings.pyfile.Migrations
The following migration will:
It does not migrate the Journal CSV, so as soon as possible the following script should also be run in production:
I also think that we will want to go back and check after a week of deployment, as we will probably need to manually delete the old journal csv and public data dump records that will be a hang-over from the previous version.
Once these scripts have been run, we may also want to upgrade all the users who will be given premium from the start. This can be done with:
The
[csv of users and roles]should be provided by @dommitchell and is of the form (do not include a header row):Monitoring
We probably should monitor to ensure the PDD is successfuly generated every day