Fixing build issues on clean RedHat 7 with openblas and lapack installed.#2
Closed
pdworzynski wants to merge 1 commit intoDReichLab:masterfrom
Closed
Fixing build issues on clean RedHat 7 with openblas and lapack installed.#2pdworzynski wants to merge 1 commit intoDReichLab:masterfrom
pdworzynski wants to merge 1 commit intoDReichLab:masterfrom
Conversation
…packe.h to include dir, added -llapacke flag to linker cmd.
Contributor
|
I agree that lapacke.h does not belong in the include folder. Is lapacke_mangling.h needed there though? |
Contributor
|
This has been resolved by removing the unnecessary lapacke.h files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues when compiling the source on standard RedHat 7 with gcc 4.8.3 with openblas and lapack installed from repo.
GCC would complain that "lapacke_mangling.h" file, referenced by "lapacke.h" could not be found. This could be solved by either removing "lapacke.h" from include directory and relying on system wide header or by adding "lapacke_mangling.h" to include, which i did for the sake of compliance.
Also, GCC linker would not find lapack functions without "-llapacke" flag passed to linker cmd.