Skip to content

Conversation

@mspalti
Copy link
Member

@mspalti mspalti commented Oct 9, 2018

No description provided.


For example, starting with the following eperson field data:
```json
"password": "oldpassword",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to note that this is not a real scenario as we will be unable to know the password of existent user

```
the replace operation `[{ "op": "replace", "path": "/password", "value": "newpassword"]` will result in :
```json
"password": "newpassword",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to like that... I know that this is what happen right now as we have the password in-memory but we should eventually consider the need to reload the entity after the update to be able to serialize information automatically updated for some reason (think about a last_modified or other generated value). In this later case we will be unable to provide the password after the update....
I'm not sure about what to suggest here... maybe we can add a custom serialized that will always expose the password as ***** or we can exclude the password from the returned object (I tend to prefer this solution)

@abollini
Copy link
Member

@mspalti can you solve the conflict and add a notice about the password issue in the returned object?
something like:
The new password is currently returned after an update but this could be revisited later, see #30

@mspalti
Copy link
Member Author

mspalti commented Oct 22, 2018

@abollini, I added the note as you suggested.

Copy link
Member

@abollini abollini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tdonohue
Copy link
Member

@mspalti : it looks like we have a minor merge conflict in this PR. Could you resolve this, so we can merge?

@abollini abollini merged commit 3ee3d0d into DSpace:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants