Use several modern Node.js patterns #4632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorth
added
improvement
dependencies
Use the the `node:` protocol when importing Node.js builtin modules and enable rule in eslint to enforce. The `node:` protocol for Node.js builtin modules has been available since Node.js v14. See: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/enforce-node-protocol-usage.md
We can use the Node.js Fetch API directly instead of relying on an external dependency.
Modern Node.js can watch natively so we don't need nodemon anymore.
alanorth
force-pushed
the
modern-node
branch
2 times, most recently
from
2ac3cf4 to
4d70510
Compare
tdonohue
added
the
1 APPROVAL
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
tdonohue
added
the
port to dspace-9_x
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
12 tasks
Contributor
|
Has this been tested on Windows development environments? |
Contributor
Author
|
Hi @tamu-sad-iii. I have not personally tried this on Windows. These "modern" Node.js patterns use built-in Node APIs and functionality, so I assume they are better supported than external modules etc. Do you build DSpace on a Windows system? If there are problems you can help us diagnose and if need be, we can revert the changes. Thanks. |
12 tasks
tdonohue
removed
the
port to dspace-9_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Node.js platform has evolved in recent years and there are some new patterns we should take advantage of.
See: https://kashw1n.com/blog/nodejs-2025/
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
node:prefix when importing built-in dependencies and add an eslint plugin to enforceInclude guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Make sure the frontend builds and runs as expected, especially the builds that use watch like
npm run start:dev.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.