Revert "New RTCM configuration" #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieryAtFnal
approved these changes
Nov 25, 2025
Contributor
bieryAtFnal
left a comment
bieryAtFnal
left a comment
There was a problem hiding this comment.
I have run regression tests from daqsystemtest, dfmodules, trigger, asiolibs, and crtmodules with these changes and the corresponding changes in appmodel and daqsystemtest, and the tests that were expected to pass did so. (My software area started with the v5.5.0 RC2 build, included the repos that have changes for RC3, and included these changes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #419
Reverting due to failures of integtests in daqsystemtest (see above), and also suspect we need to look at other places where the config needs changes/updates (dfmodules integtests, dundedaq_conf_reader, ...)