Skip to content

Conversation

@wesketchum
Copy link
Contributor

@wesketchum wesketchum commented Nov 26, 2025

Description

This reverts commit dcf31a7.

See #419 for the original PR: this PR reverts the revert commit, to essentially replicate that PR.

Addresses #415, and more details should be located there.

This PR also needs:

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Still need additional checks on other repos (e.g. dfmodules)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@wesketchum
Copy link
Contributor Author

Added PR for dfmodules which resolves large_trigger_record_test.py and insufficient_disk_space_test.py tests there. I know at least we still need to check dunedaq_conf_reader ... probably another check across repos for other RTCM usage in tests also worthwhile.

@jcfreeman2 jcfreeman2 deleted the branch prep-release/fddaq-v5.5.0 December 17, 2025 21:35
@jcfreeman2 jcfreeman2 closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants