Add unit tests and apply clippy recommendations#30
Open
AlejandroMinaya wants to merge 3 commits intoDVDTSB:mainfrom
Open
Add unit tests and apply clippy recommendations#30AlejandroMinaya wants to merge 3 commits intoDVDTSB:mainfrom
AlejandroMinaya wants to merge 3 commits intoDVDTSB:mainfrom
Conversation
Adds 45 unit tests across the four pure-logic source files (byte.rs, config.rs, app/change.rs, app/utils.rs), covering byte classification, color parsing, undo/redo, cursor navigation, buffer ops, and data mutation. ✻ Generated with Claude Code
test: Add unit tests for byte, config, change, and utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy fixes
Minor code quality improvements flagged by
cargo clippy:events.rs:return ();→returnrender.rs: removed redundantusizecast and trailing.into()on an already-compatible typeutils.rs:>= self.data.len() + 1→> self.data.len()(equivalent, idiomatic)config.rs:if/elseonResult→match; nestedif letblocks → let-chains (if let A && let B)Unit tests (45 tests, 0 new dependencies)
Tests are added inline (
#[cfg(test)]) to the four pure-logic modules. TUI-dependent modules(
render.rs,events.rs,state.rs) are excluded as they require a live terminal.src/byte.rsByteTypeclassification for all 5 variants,get_hex(),value()src/config.rstoml_value_to_color()for named/index/RGB + error cases,read_config()with missing file,Config::default()src/app/change.rsdo_change/undo/redofor Edit, Insert, and Delete variantssrc/app/utils.rsget_idx/set_idx, all cursor movement, buffer ops, afreplace/insert/delete_data,selection_rangecargo testpasses locally with all 45 tests green.